Skip to content

Fix memory leak in hkdf_expand #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix memory leak in hkdf_expand #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion generator/generate_handshake_circuits.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,8 +410,9 @@ void hkdf_expand(block *key, int key_len, block *info, int info_len, block *outp
block cur_T[256];
int cur_T_len = 0;

auto input = new block[cur_T_len + info_len + 8];

for (int i = 1; i <= N; i++) {
auto input = new block[cur_T_len + info_len + 8];
for (int j = 0; j < cur_T_len; j++) {
input[j] = cur_T[j];
}
Expand Down Expand Up @@ -441,6 +442,8 @@ void hkdf_expand(block *key, int key_len, block *info, int info_len, block *outp
}
}
}

delete[] input;
}

void hkdf_expand_label(block *key, int key_len, const char *label, block *context, int context_len, block *output,
Expand Down