Skip to content
This repository has been archived by the owner on May 5, 2024. It is now read-only.

Removed JRI deps from POM. #48

Merged
merged 2 commits into from Jun 2, 2015
Merged

Removed JRI deps from POM. #48

merged 2 commits into from Jun 2, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jun 2, 2015

No description provided.

@tomas-pluskal
Copy link
Member

Thanks!
I guess we can then also completely remove the src/lib/rJava folder?

@ghost
Copy link
Author

ghost commented Jun 2, 2015

Yep. Good thinking. Done!

@tomas-pluskal
Copy link
Member

Thanks! Awesome work!

tomas-pluskal added a commit that referenced this pull request Jun 2, 2015
@tomas-pluskal tomas-pluskal merged commit 918063b into mzmine:master Jun 2, 2015
@ghost
Copy link
Author

ghost commented Jun 2, 2015

Well, I hope so. We'll have to test it intensively...
I tried another approach for the "Deconvolution module design" but this is not that interesting, in the end. In case you're curious: https://github.com/golgauth/mzmine2/tree/rserve-integration-6.1/src/main/java/net/sf/mzmine/modules/peaklistmethods/peakpicking/deconvolution
Cheers.

@dyrlund
Copy link
Member

dyrlund commented Jun 2, 2015

I did some tests of the new Rserve and it works great so far. Really nice work Gauthier! I expect that this will reduce the issues many users experience with the R integration. And it is so nice that the R dependent modules can now be multi-threaded.

@ghost
Copy link
Author

ghost commented Jun 2, 2015

Glad to here that! I had it in the tracks for while and was looking forward to find time to pull it into the main trunk (which was moving faster than me). And the jet lag with Japan (I mean Tomas) is pretty much "not in our favor", unless you wake up early ;) (you are based in Denmark, ain't you? You must be quite in the same time zone than me).

Hope not too many bug reports will blow up, now - beta-testing time...

Note: Rserve being also able to work remotely. We could think, in the future, about getting MZmine in headless mode (mainly) to request for R tasks to another computer (i.e. super-calculator), .... That's a very powerful toy to play with.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants