Skip to content

osu!.db 20250107 fix #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mzhang28 merged 1 commit into from
May 7, 2025
Merged

osu!.db 20250107 fix #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/db/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@ pub struct Db {
impl DbBeatmap {
fn read_star_rating(
mut reader: impl io::BufRead,
version: u32,
) -> DbResult<Vec<(Mods, f64)>> {
let count = reader.read_u32::<LittleEndian>()?;
let ratings = (0..count)
Expand All @@ -242,8 +243,13 @@ impl DbBeatmap {
Mods::from_bits(value).ok_or(DbError::InvalidMods(value))?
},
{
assert_eq!(reader.read_u8()?, 0x0D);
reader.read_f64::<LittleEndian>()?
assert_eq!(reader.read_u8()?, 0x0C);
// "Until database version 20250107, this was a collection of Int-Double pairs"
if version > 20250107 {
reader.read_f32::<LittleEndian>()? as f64
} else {
reader.read_f64::<LittleEndian>()?
}
},
))
})
Expand Down Expand Up @@ -293,10 +299,10 @@ impl DbBeatmap {
hp_drain: reader.read_f32::<LittleEndian>()?,
overall_difficulty: reader.read_f32::<LittleEndian>()?,
slider_velocity: reader.read_f64::<LittleEndian>()?,
std_star_rating: Self::read_star_rating(&mut reader)?,
std_taiko_rating: Self::read_star_rating(&mut reader)?,
std_ctb_rating: Self::read_star_rating(&mut reader)?,
std_mania_rating: Self::read_star_rating(&mut reader)?,
std_star_rating: Self::read_star_rating(&mut reader, version)?,
std_taiko_rating: Self::read_star_rating(&mut reader, version)?,
std_ctb_rating: Self::read_star_rating(&mut reader, version)?,
std_mania_rating: Self::read_star_rating(&mut reader, version)?,
drain_time: Millis(reader.read_i32::<LittleEndian>()? * 1000), // the file contains seconds, not milliseconds
total_time: Millis(reader.read_i32::<LittleEndian>()?),
preview_time: Millis(reader.read_i32::<LittleEndian>()?),
Expand Down