Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing from documentation: .gitignore check #117

Open
mjomble opened this issue Apr 30, 2018 · 3 comments
Open

Missing from documentation: .gitignore check #117

mjomble opened this issue Apr 30, 2018 · 3 comments

Comments

@mjomble
Copy link

mjomble commented Apr 30, 2018

The documentation only mentions .npmignore, but the rule also checks .gitignore:

filePath = path.join(basedir, ".gitignore")

@aladdin-add
Copy link
Contributor

The reason I'm not sure about whether it is a good idea is because it seems like not necessarily something specific to Node.js libs/apps, so it might not be in scope for this plugin.

@mysticatea
Copy link
Owner

@mjomble
Copy link
Author

mjomble commented Jul 18, 2018

@aladdin-add to clarify, I'm not requesting a change of behavior, just a documentation update to reflect behavior that already exists.

ota-meshi pushed a commit to ota-meshi/eslint-plugin-node that referenced this issue Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants