Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support ESLint 7.x #30

Merged
merged 8 commits into from
May 12, 2020
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@v1
with:
node: 12.x
node: 14
- name: Install Packages
run: npm install
- name: Lint
Expand All @@ -28,37 +28,37 @@ jobs:

strategy:
matrix:
eslint: [6.x]
node: [14.x]
eslint: [7]
node: [14]
MichaelDeBoey marked this conversation as resolved.
Show resolved Hide resolved
os: [ubuntu-latest]
include:
# On other platforms
- eslint: 6.x
node: 14.x
- eslint: 7
node: 14
os: windows-latest
- eslint: 6.x
node: 14.x
- eslint: 7
node: 14
os: macos-latest
# On old Node.js versions
- eslint: 6.x
node: 12.x
- eslint: 7
node: 12
os: ubuntu-latest
- eslint: 6.x
node: 10.x
os: ubuntu-latest
- eslint: 6.x
node: 8.x
- eslint: 7
node: 10
mysticatea marked this conversation as resolved.
Show resolved Hide resolved
os: ubuntu-latest
# On old ESLint versions
- eslint: 5.x
node: 14.x
- eslint: 6
node: 14
os: ubuntu-latest
- eslint: 5
node: 14
os: ubuntu-latest
- eslint: 4.x
node: 14.x
- eslint: 4
node: 14
os: ubuntu-latest
# On the minimum supported ESLint/Node.js version
- eslint: 4.x
node: "8.0.0"
- eslint: 4
node: 8.10.0
mysticatea marked this conversation as resolved.
Show resolved Hide resolved
os: ubuntu-latest

runs-on: ${{ matrix.os }}
Expand Down
5 changes: 4 additions & 1 deletion lib/rules/no-unicode-codepoint-escapes.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ module.exports = {
for (const match of codePointEscapeSearchGenerator(text)) {
const start = match.index
const end = start + match[0].length
const range = [start + node.start, end + node.start]
const range = [
start + node.range[0] + 1,
end + node.range[0] + 1,
]
context.report({
node,
loc: {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"codecov": "^3.5.0",
"eslint": "^6.2.2",
"eslint4b": "^6.2.2",
"espree": "^6.1.1",
"espree": "^7.0.0",
"globals": "^12.0.0",
"mocha": "^6.2.0",
"npm-run-all": "^4.1.5",
Expand Down