Update RowDataPacket.js #1188
Open
Update RowDataPacket.js #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ans the data would be omitted if using nestTables. This fix only appends data to table objects if there is a table name, otherwise it's appended to the root object.
…he result object correctly. Changed table to concrete table instead of temporary table because we can't run subqueries on temporary tables.
|
Hi @ashwinks , that's for this PR! I'm looking over it, and it doesn't seem to be backwards-compatible, is that correct? It seems like we were storing the columns under the key |
dougwilson
force-pushed
the
master
branch
4 times, most recently
from
5847ec8 to
be37e88
Compare
dougwilson
force-pushed
the
master
branch
3 times, most recently
from
65c4c0c to
fa96a75
Compare
dougwilson
force-pushed
the
master
branch
2 times, most recently
from
638d79d to
88bade0
Compare
dougwilson
force-pushed
the
master
branch
2 times, most recently
from
946727b to
37fbbdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using subqueries in select statements, there's no table which means the data would be omitted if using nestTables. This fix only appends data to table objects if there is a table name, otherwise it's appended to the root object.