Using node-mysql with promises

[chrisveness]

Can node-mysql be used with promises, or only with callbacks? If it can't, can you suggest how best to use it within a promises structure? (I'm a bit lost with promisify, bluebird, Q, ...)

[dougwilson]

This library uses callbacks because they are more performant and also let you do anything. If you want to use promises with callbacks, bluebird I know offers this functionality. Here is an example:

var Promise = require('bluebird')
var mysql = require('mysql')

var connection = mysql.createConnection({ ... })

Promise.promisify(connection.query, connection)('SELECT 1').then(function (rows) {
  console.log('got rows!')
  console.dir(rows)
  connection.end()
})

[gajus]

This library uses callbacks because they are more performant and also let you do anything.

Would be nice to see some benchmarks. The time that promise resolution takes, in the context of roundtrips, is negligible.

[dougwilson]

The only way to truely benchmark it would be to convert at least the external APIs in this module to promises and then make a benchmark suite and use it to compare this module with and without them.

@sidorares may have some thoughts on this as well.

[gajus]

The only way to truely benchmark it would be to convert at least the external APIs in this module to promises and then make a benchmark suite and use it to compare this module with and without them.

The first part has been done, https://www.npmjs.org/package/promise-mysql.

[sidorares]

I've been doing some benchmarks recently, I'll add promise-mysql as well and post results here

[dougwilson]

@sidorares cool :) and @gajus ooo, I didn't know that wrapper module existed (though I don't use promises, so I guess that's understandable).

[sidorares]

I'll post more detailed results later, but rough numbers for simple "select 1" x 100000 times:
7300 qps - node-mysql
6400 qps - promise-mysql
8338 qps - node-mysql2

io.js:
8300 qps - node-mysql
7000 qps - promise-mysql
14200 qps - node-mysql2

So there is some overhead, probably less visible on bigger resultsets (or slower queries).
There is a big difference between node ( v0.10.33 ) and io.js - likely due to newer V8 and turbofan.

[gajus]

What library for promises did you use?

On Dec 19, 2014, at 08:07, Andrey Sidorov notifications@github.com wrote:

I'll post more detailed results later, but rough numbers for simple "select 1" x 100000 times:
7300 qps - node-mysql
6400 qps - promise-mysql
8338 qps - node-mysql2

io.js:
8300 qps - node-mysql
7000 qps - promise-mysql
14200 qps - node-mysql2

So there is some overhead, probably less visible on bigger resultsets (or slower queries).
There is a big difference between node ( v0.10.33 ) and io.js - likely due to newer V8 and turbofan.

—
Reply to this email directly or view it on GitHub.

[sidorares]

https://www.npmjs.org/package/promise-mysql ( bluebird )

[gajus]

It would be interesting to test it using the native (0.11.13) promises,
https://twitter.com/jongleberry/status/462260349173907456.

On Fri, Dec 19, 2014 at 11:59 AM, Andrey Sidorov notifications@github.com
wrote:

https://www.npmjs.org/package/promise-mysql ( bluebird )

—
Reply to this email directly or view it on GitHub
#929 (comment).

[dougwilson]

BTW I'm going to reopen this issue while discussion continues.

[chrisveness]

It's been helpful following this discussion I prompted, but in fact I have the luxury of being in the position of planning future development rather than having to go live immediately, and am hoping that (providing Node.js v0.12 appears at some point!) I will be able to skip a generation, pass over promises, and go straight to generators using Koa with something like co-mysql or mysql-co.

Any views or suggestions would be welcome!