Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional external rate limit file. #425

Closed
wants to merge 1 commit into from
Closed

Conversation

dracos
Copy link
Member

@dracos dracos commented Mar 13, 2024

@dracos dracos requested a review from neprune March 13, 2024 16:11
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.23%. Comparing base (43abf6f) to head (ddaa49e).

Files Patch % Lines
mapit/ratelimitcache.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
- Coverage   75.27%   75.23%   -0.04%     
==========================================
  Files          47       47              
  Lines        2811     2815       +4     
==========================================
+ Hits         2116     2118       +2     
- Misses        695      697       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@neprune neprune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@dracos
Copy link
Member Author

dracos commented Mar 15, 2024

Actually doing same thing in the mapit.mysociety.org repo instead.

@dracos dracos closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants