Block for extra content in area/postcode info #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for cobrands that want to display a small amount of custom data, or a message to users, without overriding the whole template.
dracos
reviewed
Feb 17, 2017
| {% url json_view postcode=postcode.postcode as json_url %} | ||
| <p>{% blocktrans %}Get <a href="{{ json_url }}">this data as JSON</a>{% endblocktrans %}</p> | ||
|
|
||
| {% block area_info_extra %}{% endblock %} |
There was a problem hiding this comment.
Should this be postcode_info_extra?
There was a problem hiding this comment.
I considered it, but then the HTML element it appears in is called area_info (even on the postcode page) – so I stuck with area_info_extra because it's extra content to go in the .area_info element.
There was a problem hiding this comment.
Yeah, I noticed that after (and merged+deployed as you see) :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for cobrands that want to display a small amount of custom data, or a message to users, without overriding the whole template.
(We’re using this in MapIt UK to display a message about business users and paid plans.)