Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Django before version 1.8 #209

Merged
merged 2 commits into from
Nov 3, 2015
Merged

Conversation

dracos
Copy link
Member

@dracos dracos commented Oct 27, 2015

Slightly early, as 1.7 has extended support until December, but might as well get it out the way.

@stevenday
Copy link
Contributor

Wow, so much deleted code! This is great 🚀

FWIW, I tested this on a local vm that was running Django 1.7 before, and the one thing I had to do was clear my cache (as well as running migrations) - I wonder if it's worth adding some kind of upgrade note to this effect when you release this? (As well as bumping & signposting the version number so that people using older Djangos can find a version that works?)

@stevenday
Copy link
Contributor

Ah, one more thing, I just noticed we get a warning:

WARNINGS:
?: (1_8.W001) The standalone TEMPLATE_* settings were deprecated in Django 1.8 and the TEMPLATES dictionary takes precedence. You must put the values of the following settings into your default TEMPLATES dict: TEMPLATE_DEBUG.

@dracos dracos merged commit e528619 into master Nov 3, 2015
@dracos dracos removed the Reviewing label Nov 3, 2015
@dracos dracos deleted the drop-django-1.4-1.7 branch December 22, 2015 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants