Add Sweden to list of MapIt countries #184
Conversation
|
Hi :) A few random questions - you say postal codes are seven characters, but http://en.wikipedia.org/wiki/Postal_codes_in_Sweden says they are five? I think there might be a bug in terms of partial postcodes, to do with length assumption, but we can look at that after some more details. I'm coincidentally just merging the i18n branch which means you can supply a Swedish translation too if you wish :) |
|
Hi, Matthew! I was not the one who wrote this code, I just found that it was never submitted back to the project, and made this pull request without even noticing that. Swedish postcodes are for sure not seven digits. I will try to get hold of the person who wrote the code and ask, though. :) I'll get back to you. (It's somewhat common that people write post codes by prepending "SE-" like so: "SE-41516". The other common format, except the "41516" one, is "415 16", with a space between the last two digits.) |
|
Hi, again! So, no one knows how that got in there. It would suffice for us to simply use "\d{3}\s?\d{2}", to match either "41516" or "415 16". What would it mean to supply a Swedish translation? How many strings would that be to translate, approximately? Can we do it through Transifex? Thanks! |
|
Do update this pull request then :) I'll take a look at the partial postcode issue soon. |
|
Sure, I will! Could you add the Transifex account "jonkri" to the project so that I could edit the "mapit" resource? Thanks! |
|
Sorry, that probably isn't clear; you don't need a mapit_se resource as you have nothing country specific to translate – you only need to translate the "mapit" resource. I've invited you to it :) |
|
I have now translated the resource to Swedish. :) |
|
Added to version 1.4 branch as 15e205e, will be merged soon, thanks :) |
No description provided.