[Scorecards] Added theme and theme single page #791
Conversation
|
@zarino I'll move the thematics to the |
lucascumsille
force-pushed
the
thematic-infographics
branch
from
39bd4e7 to
14865f5
Compare
- Added `/themes` page to list all existing themes - Also list all the themes in the `/sections` page - For the theme single pages infographics are displayed.
lucascumsille
force-pushed
the
thematic-infographics
branch
from
14865f5 to
007b693
Compare
|
@zarino I just rebased with master and moved the thematic infographics to the |
zarino
left a comment
zarino
left a comment
There was a problem hiding this comment.
This largely looks good to me! Only one small thing I spotted.
Guess we should keep this PR in review until the Cost Saving infographic is done, then we can launch both together?
In the meantime, you could always come along to our next catchup call with CEUK and show them what we’re planning, see whether they have any comments!
conf/social_graphics.py
Outdated
| "adaptation": { | ||
| "pdf": { | ||
| "src_pdf": "scoring/img/social-graphics-2025/adaptation.pdf", | ||
| "src_jpg": "scoring/img/social-graphics-2025/adaptation.png", |
There was a problem hiding this comment.
A minor thing, but ideally these src_jpg files really should be jpegs and not pngs, because we mark them up as having a image/jpeg mime type in the opengraph tags. (OpenGraph parsers probably then go on to ignore the tags, but 🤷.) It looks like we’ve used a mixture of jpg and png files for previous sections/nations.
There was a problem hiding this comment.
If we want to make some of them jpgs and some of them pngs (eg: for filesize optimisation) then we could potentially change the template code to infer the right mime type from the file extension 🤔
There was a problem hiding this comment.
I think I'll delete the PNGs and just have jpgs
|
We are awaiting for some copy related from CEUK, before merging. Regarding the opengraph format. I'll handle that on another PR where I'll replace them with png and stop using jpg. |
- Replaced all JPG main images for graphics with PNG - Replaced button label from JPG to PNG
/themespage to list all existing themes/sectionspageScreen.Recording.2026-01-20.at.13.55.48.mov
Screen.Recording.2026-01-20.at.13.56.09.mov