Fix array size issue #31
Conversation
Updated variable types to optimize bytes used and fixed rainBucket array size issue
|
Maybe update SKETCH_VERSION to 2.1? https://github.com/petewill/MySensorsArduinoExamples/blob/7296714adf7cb0582c109b1b7c2402fe05c565cd/examples/RainGauge/RainGauge.ino#L56 |
|
This is a nitpick (no need to change this PR, but perhaps something to think about in the future), and maybe of personal taste, but I like when different things go into different commits. So I would have liked one commit for the variable type change and one commit for the array length bug fix. Separate commits makes it easier to see what has changed, and makes it possible to revert one change without undoing the other. It would also make it easier to see the commit message and understand the change. In the current way, the first line of the commit message only reflects one of the changes. A rule I learned some years ago and have found useful is that whenever you write the word "and" in a commit message, consider if it should be two separate commits. git commit -p is often useful when splitting commits. |
Forgot to update the version number in the previous commit. I also commented out the MY_RF24_PA_LEVEL field as people may be using a different radio.
|
@mfalkvidd Good feedback. I updated the version number. I think that is good practice to do separate commits. I'll do that in the future. |
2 participants
Updated variable types to optimize bytes used and fixed rainBucket array
size issue