[RFC] Mysensors HAL retry hack

MyConfig.h

@@ -1111,6 +1111,15 @@
 #define MY_TRANSPORT_DISCOVERY_INTERVAL_MS (20*60*1000ul)
 #endif
 
+/**
+ * @def MY_TRANSPORT_SEND_RETRIES
+ * @brief If defined to a positive number N, the node will try to send the payload to the 
+ * uplink up to N times before actually failing. Useful when working in a noisy environment
+ * @note Setting this option too high will 
+ * 
+ */
+//#define MY_TRANSPORT_SEND_RETRIES (5)
+
 /**
  *@def MY_TRANSPORT_UPLINK_CHECK_DISABLED
  *@brief If defined, disables uplink check to GW during transport initialisation

hal/transport/MyTransportHAL.cpp

@@ -173,7 +173,15 @@ bool transportHALSend(const uint8_t nextRecipient, const MyMessage *outMsg, cons
 	const uint8_t finalLength = len;
 #endif
 
+#ifdef MY_TRANSPORT_SEND_RETRIES
+	uint8_t retries = MY_TRANSPORT_SEND_RETRIES;
+	bool result = false; 
+	while (retries-- && (!result)) {
+		result = transportSend(nextRecipient, (void *)tx_data, finalLength, noACK);
+	}
+#else
 	bool result = transportSend(nextRecipient, (void *)tx_data, finalLength, noACK);
+#endif
 	TRANSPORT_HAL_DEBUG(PSTR("THA:SND:MSG LEN=%" PRIu8 ",RES=%" PRIu8 "\n"), finalLength, result);
 	return result;
 }

hal/transport/RF24/driver/RF24registers.h

@@ -41,10 +41,14 @@
 #define RF24_CRC_16				(3)
 
 // ARD, auto retry delay
+#ifndef RF24_SET_ARD
 #define RF24_SET_ARD			(5)	//=1500us
+#endif
 
 // ARD, auto retry count
+#ifndef RF24_SET_ARC
 #define RF24_SET_ARC			(15)
+#endif
 
 // nRF24L01(+) register definitions
 #define RF24_REG_NRF_CONFIG		(0x00)

keywords.txt

@@ -66,6 +66,7 @@ MY_SIGNAL_REPORT_ENABLED	LITERAL1
 MY_SLEEP_TRANSPORT_RECONNECT_TIMEOUT_MS	LITERAL1
 MY_SMART_SLEEP_WAIT_DURATION_MS	LITERAL1
 MY_TRANSPORT_CHKUPL_INTERVAL_MS	LITERAL1
+MY_TRANSPORT_SEND_RETRIES  LITERAL1
 MY_TRANSPORT_DISCOVERY_INTERVAL_MS	LITERAL1
 MY_TRANSPORT_MAX_TSM_FAILURES	LITERAL1
 MY_TRANSPORT_MAX_TX_FAILURES	LITERAL1