Skip to content

Add on_delete kwargs to foreign keys #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 13, 2017
Merged

Add on_delete kwargs to foreign keys #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1acb35b
Add on_delete kwargs to foreign keys
tpict Dec 12, 2017
73f2dd4
Don't call user.is_authenticated
tpict Dec 12, 2017
88752dc
Revert "Don't call user.is_authenticated"
tpict Dec 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion feature_flipper/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ class FeatureFlipper(AbstractFeatureFlipper):
"""
USER_FEATURE_FIELD = 'user'

user = models.ForeignKey(flipper_settings.AUTH_USER_MODEL)
user = models.ForeignKey(
flipper_settings.AUTH_USER_MODEL, on_delete=models.CASCADE)

class Meta:
swappable = 'FEATURE_FLIPPER_MODEL'
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
author_email='scott.walton@mypebble.co.uk',
description='A simple, customisable, feature flipper',
url='https://github.com/mypebble/django-feature-flipper.git',
version='0.1.1',
version='0.1.2',
packages=find_packages(),
license='MIT',
long_description=LONG_DESCRIPTION,
Expand Down
5 changes: 3 additions & 2 deletions test_project/test_project/test_features/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ class Company(models.Model):
"""
"""
company_name = models.CharField(max_length=10, default='')
user = models.ForeignKey(settings.AUTH_USER_MODEL)
user = models.ForeignKey(
settings.AUTH_USER_MODEL, on_delete=models.CASCADE)

def __unicode__(self):
"""
Expand All @@ -23,4 +24,4 @@ class TestFeatureFlipper(AbstractFeatureFlipper):
"""
USER_FEATURE_FIELD = 'company'

company = models.ForeignKey(Company)
company = models.ForeignKey(Company, on_delete=models.CASCADE)