Update nl_NL.csv #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postNL to PostNL
Closed
MatthijsBreed
referenced
this pull request
in MatthijsBreed/magento
Nov 3, 2021
When Magento MSI is not enabled, the `bin/magento setup:di:command` fails on `Model/Source/SourceItem.php`
This is because the objectmanager cannot instantiate the `Magento\InventoryApi\Api\SourceItemRepositoryInterface`:
```
Area configuration aggregation... 5/9 [===============>------------] 55% 18 secs 334.0 MiB
In ClassReader.php line 45:
Impossible to process constructor argument Parameter #1 [ <required> Magento\InventoryApi\Api\SourceItemRepositoryInterface $sourceItemRepository ] of MyParcelNL\Magento\Model\Source\SourceItem class
In ClassReader.php line 34:
Class Magento\InventoryApi\Api\SourceItemRepositoryInterface does not exist
```
This PR applies the same fix as PR myparcelnl#577 to the SourceItem class itself
peterjaap
added a commit
to peterjaap/magento
that referenced
this pull request
Jan 24, 2023
Fix proof:
```
php > $data['date'] = null;
php > $dateTime = date('d-m-Y H:i', strtotime($data['date']));
PHP Deprecated: strtotime(): Passing null to parameter myparcelnl#1 ($datetime) of type string is deprecated in php shell code on line 1
PHP Stack trace:
PHP 1. {main}() php shell code:0
PHP 2. strtotime($datetime = NULL) php shell code:1
Deprecated: strtotime(): Passing null to parameter myparcelnl#1 ($datetime) of type string is deprecated in php shell code on line 1
Call Stack:
32.4666 603888 1. {main}() php shell code:0
32.4666 603888 2. strtotime($datetime = NULL) php shell code:1
php > $dateTime = date('d-m-Y H:i', strtotime($data['date'] ?? ''));
php > var_dump($dateTime);
php shell code:1:
string(16) "01-01-1970 00:00"
```
peterjaap
added a commit
to peterjaap/magento
that referenced
this pull request
Jan 25, 2023
We're getting this error a lot; ``` MyParcelNL\Magento\Plugin\Magento\Sales\Api\Data\OrderExtension::useEntityId(): Argument myparcelnl#1 ($entityId) must be of type int, string given, called in /data/web/releases/20230124154227/vendor/myparcelnl/magento/Plugin/Magento/Sales/Api/Data/OrderExtension.php on line 65 ``` `useEntityId` expects an int; `private function useEntityId(int $entityId): array` However, you're exploding a string and not casting it; ``` $explodePath = explode('/', $path ?? ''); [$searchColumn, $searchValue] = $this->useEntityId(end($explodePath)); ``` So I added `(int)` to cast the numeric value to an int.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postNL to PostNL