Skip to content

Fix for Modal Freeze Issue on iOS. Ref thread: https://github.com/facebook/react-native/pull/32450 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nitish24p merged 1 commit into from
Jan 25, 2023
Merged

Fix for Modal Freeze Issue on iOS. Ref thread: https://github.com/facebook/react-native/pull/32450 #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions React/Views/RCTModalHostView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,27 @@ - (void)didUpdateReactSubviews
// Do nothing, as subview (singular) is managed by `insertReactSubview:atIndex:`
}

/**
Fix for Modal Freeze issue on iOS
Ref Thread: https://github.com/facebook/react-native/pull/32450
*/
// - (void)dismissModalViewController
// {
// if (_isPresented) {
// [_delegate dismissModalHostView:self withViewController:_modalViewController animated:[self hasAnimationType]];
// _isPresented = NO;
// }
// }

- (void)dismissModalViewController
{
if (_isPresented) {
[_delegate dismissModalHostView:self withViewController:_modalViewController animated:[self hasAnimationType]];
_isPresented = NO;
}
}
{
dispatch_async(dispatch_get_main_queue(), ^{
if (self->_isPresented) {
[self->_delegate dismissModalHostView:self withViewController:self->_modalViewController animated:[self hasAnimationType]];
self->_isPresented = NO;
}
});
}

- (void)didMoveToWindow
{
Expand Down