Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
ml4w-wallpaperscript to updatewallpaper_cacheonly when--skip-themingis not set.Changes
ml4w-wallpaperscript to updatewallpaper_cacheonly when--skip-themingis not set.Context
Right now
wallpaper_cacheis used for theming purposes. In the event thatml4w-wallpaperis called with the--skip-themingflag set, the related theming aspects are not updated, but the cache file is. The next time the user logs into Hyprland, the autostart logic callsml4w-wallpaperusing normal theming logic. This causes the theming to update itself based on the cached file (which was explicitly marked as not to be used for theming) which is not intended.This change moves the updating of the cache file to be inside the check for whether to re-theme, and only does so if
--skip-themingwas not set.How Has This Been Tested?
Tested by running the script with and without the
--skip-themingflag, and verified the contents ofwallpaper_cachewere as intended. Also tried to set the wallpaper using the--skip-themingflag, restarting Hyprland, and verifying that the theming was not changed from the new wallpaper file.Checklist
Please ensure your pull request meets the following requirements: