This repository was archived by the owner on Aug 27, 2018. It is now read-only.
Refactor events to be interface-based #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myitcv
changed the title
myitcv
force-pushed
the
events
branch
2 times, most recently
from
4d1273c to
355166b
Compare
myitcv
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves away from the anti-pattern of having
functype fields in props (or state for that matter). This is already "enforced" inreactGen(by virtue of the user having to define an equals method if their props/state struct type value is not comparable); so this change is essentially closing a loophole that was being exploited by the core React components