This repository was archived by the owner on Aug 27, 2018. It is now read-only.
Better core component props support #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via an improved
reactGen
, we now support props type declaration "explosion"Prior to this PR, the pattern for writing core React component props (or indeed any props type that embed another struct type) was:
This pattern was necessary so that one could easily provide a field value without having to initialise deeply nested embedded struct values.
This callback pattern however made code much harder to write and read. Painful in fact.
Props type template explosion
reactGen
now knows how to "explode" template struct type declarations for props types:gets exploded into:
This allows a far more natural instantiation of components.
Compare how we used to have to do things
with the new world post this PR: