Skip to content
This repository was archived by the owner on Aug 27, 2018. It is now read-only.

Fix shouldComponentUpdate check #34

Merged
merged 1 commit into from
Mar 27, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions cmd/reactGen/gen.go
Original file line number Diff line number Diff line change
Expand Up @@ -356,19 +356,24 @@ func (g *gen) genComp(defName string) {
cg.pln()

cg.pt(`
func ({{.Recv}} *{{.Name}}Def) ShouldComponentUpdateIntf(nextProps interface{}) bool {
{{if and .HasProps -}}
func ({{.Recv}} *{{.Name}}Def) ShouldComponentUpdateIntf(nextProps, prevState, nextState interface{}) bool {
res := false

{{if .HasProps -}}
{
{{if .PropsHasEquals -}}
return {{.Recv}}.Props().Equals(nextProps.({{.Name}}Props))
res = !{{.Recv}}.Props().Equals(nextProps.({{.Name}}Props)) || res
{{else -}}
return {{.Recv}}.Props() == nextProps.({{.Name}}Props)
res = {{.Recv}}.Props() != nextProps.({{.Name}}Props) || res
{{end -}}
{{else if .HasState -}}
return true
{{else -}}
// no props or state... so nothing would cause this to require re-rendering
return false
}
{{end -}}
{{if .HasState -}}
v := prevState.({{.Name}}State)
res = !v.EqualsIntf(nextState) || res
{{end -}}

return res
}

{{if .HasState}}
Expand Down
8 changes: 6 additions & 2 deletions react/examples/gen_Examples_reactGen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions react/examples/gen_ImmExamples_reactGen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 7 additions & 2 deletions react/examples/hellomessage/gen_HelloMessage_reactGen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions react/examples/hellomessage/hello_message.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ type HelloMessageProps struct {
// HelloMessage creates instances of the HelloMessage component
func HelloMessage(p HelloMessageProps) *HelloMessageDef {
res := &HelloMessageDef{}

r.BlessElement(res, p)

return res
}

Expand Down
8 changes: 6 additions & 2 deletions react/examples/immtodoapp/gen_TodoApp_reactGen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions react/examples/markdowneditor/gen_MarkdownEditor_reactGen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions react/examples/timer/gen_Timer_reactGen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions react/examples/todoapp/gen_TodoApp_reactGen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 19 additions & 3 deletions react/react.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ type generatesElement interface {
}

type Component interface {
ShouldComponentUpdateIntf(nextProps interface{}) bool
ShouldComponentUpdateIntf(nextProps, prevState, nextState interface{}) bool
Render() Element

setThis(this *js.Object)
Expand Down Expand Up @@ -207,15 +207,31 @@ func buildReactComponent(typ reflect.Type) *js.Object {

cmp.setThis(this)

var nextProps interface{} = nil
var nextProps interface{}
var prevState interface{}
var nextState interface{}

if arguments[0] != nil {
if i := arguments[0].Get(nestedProps); i != nil {
nextProps = i.Interface()
}
}

return cmp.ShouldComponentUpdateIntf(nextProps)
if arguments[1] != nil {
if i := arguments[1].Get(nestedState); i != nil {
nextState = i.Interface()
}
}

if this != nil {
if s := this.Get("state"); s != nil {
if v := s.Get(nestedState); v != nil {
prevState = v.Interface()
}
}
}

return cmp.ShouldComponentUpdateIntf(nextProps, prevState, nextState)
}))

compDef.Set(reactCompComponentDidMount, js.MakeFunc(func(this *js.Object, arguments []*js.Object) interface{} {
Expand Down
8 changes: 6 additions & 2 deletions sites/examplesshowcase/gen_App_reactGen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.