feat: sort migrations before applying #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusmelchiades
approved these changes
Jul 13, 2024
matheusmelchiades
approved these changes
Aug 7, 2024
|
Should check if order should be by file sort than className... |
mycodeself
requested changes
Aug 13, 2024
There was a problem hiding this comment.
Hi @sf0rman, thank you very much for your input.
I have simply made a change to compare the className as a string with localeCompare when sorting the migrations, This way we are not dependent on the format of the className which may change.
I'll generate a fix version with these changes right now!
Thanks again!
Edit: I messed up it with the localCompare option, I have reverted to your original code in the version 1.6.2, it works perfectly. Thank you
mycodeself
reviewed
Aug 13, 2024
Use localeCompare instead of relying on the format of the className that could change.
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
Migration files are not ordered by timestamp when running
up-command which can cause ordering issues.For example
Migration1: createCollection
Migration2: change stuff within collection
If not ordered, migration-stuff attempts to run first and fails due to dependency on Migration1 (or collection existing)
Solution
When creating a migration file, we know that all class names end with a 13-digit timestamp (
./lib/commands/new.ts:57) regardless of using a custom template or the default one.We can therefore extract timestamp from className (last 13 digits of className) and sort migrations based on this before running migrations.