Farnsworth contact dedupe #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that talkgroups with the same ID are treated as equivalent when generating farnsworth output.
Farnsworth format only allows one contact per ID, so contacts are collapsed by ID and Slot when generating the JSON. This process is lossy, resulting in some channels with talkgroups that have names which don't appear in the final farnsworth output. To avoid this issue, we pass a mapping of DMR ID to Talkgroup when generating channels. Instead of taking the channel's Talkgroup.name as-is, look up the ID in the set of known contacts and use the deduplicated name.
Similarly for channels, ensure that GroupList entries are actually present in the deduped contact list.
When generating GroupLists, lookup the member talkgroups by ID to ensure the correct name is used (after deduping).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid "invalid" references in editcp when a channel's talkgroup gets deduplicated (has the same ID, but different name).
The fix addresses invalid Contact entries in Channel and GroupList records.