Skip to content

Rework tests #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 15, 2017
Merged

Rework tests #85

merged 5 commits into from
Oct 15, 2017

Conversation

theofidry
Copy link
Collaborator

@theofidry theofidry commented Oct 15, 2017

I've did a review of the lib and did some cleanup, tweaks and added missing tests.

  • Bumped minimal version to PHP 5.6.
  • Fixed the PHPUnit config to exclude deep_copy.php from the coverage report
  • Fixed a bug when using useCloneMethod: the old object was returned unchanged instead of returning the cloned object
  • Make the coverage stricter by adding the @covers annotations

@theofidry theofidry merged commit 7a84e10 into myclabs:1.x Oct 15, 2017
@theofidry theofidry deleted the bugfix/refactor branch October 15, 2017 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant