#143 -- Add isInitialized check for PHP 7.4 typed properties.

[BusterNeece]

See issue #143 for details.

Some help writing the unit tests for this would be much appreciated; not sure how to best approach testing a version-specific piece of functionality like this.

[BusterNeece]

Minor update: the $property->isInitialized($object) method also requires that setAccessible(true) be set before it is checked, in the same style as getValue, so it needs to be moved further down in the processing. The latest commit takes care of that.

[theofidry]

Thanks for the patch!

I think for the test you could create a fixture class with typed properties along the existing ones, a test cloning it once the properties are initialised and another when it's not. Since this test should be done only in PHP 7.4 you can use a @requires PHP 7.4 tag to it

[BusterNeece]

I've created some PHP-7.4-specific unit tests and a new test class namespace to specifically address this functionality. I also added PHP 7.4 as a testing target for Travis CI.

Coveralls seems to think that the overall coverage is reduced...since this is a PHP 7.4-specific block of code, maybe that check should be suppressed for other versions?

[mnapoli]

Since the build issue is just coveralls being picky, to me it's OK to merge.

@theofidry good for you?

[theofidry]

Good for me 👍

…

On Sun 15 Dec 2019 at 19:10, Matthieu Napoli ***@***.***> wrote: ***@***.**** approved this pull request. Since the build issue is just coveralls being picky, to me it's OK to merge. @theofidry <https://github.com/theofidry> good for you? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#144?email_source=notifications&email_token=ABHPVAND2JATYITT3N7UJQ3QYZXJDA5CNFSM4JX2PIDKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPHCZSI#pullrequestreview-332278985>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABHPVAPUSASZW6R7VCLWB7TQYZXJDANCNFSM4JX2PIDA> .

[mnapoli]

Thank you @SlvrEagle23