Skip to content

Temporary fix to run tests on Travis #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 31, 2018
Merged

Conversation

Slamdunk
Copy link
Contributor

@Slamdunk
Copy link
Contributor Author

For Scrutinizer something similar should be adopted:
https://scrutinizer-ci.com/docs/guides/setting_environment_variables

It could also be set with a commit configuration file, if you prefer.

@theofidry
Copy link
Collaborator

It could also be set with a commit configuration file, if you prefer.

I think this would be better: I don't have control on the Scrutinizer account at the moment

Thanks a lot for the help!

@Slamdunk
Copy link
Contributor Author

Done. Scrutinizer triggers seem stalled, but the build passed the stage this PR aims to.

@theofidry
Copy link
Collaborator

Hm maybe it needs the complete config. Prior to your changes it was:

filter:
    excluded_paths: [vendor/*, app/*, web/*]
    
before_commands:
    - "composer install"

tools:
    php_cpd: true
    php_pdepend:
        excluded_dirs: [vendor]
    php_loc: true
    php_mess_detector: true
    php_analyzer: true
    php_code_coverage: true

@Slamdunk
Copy link
Contributor Author

Slamdunk commented May 31, 2018

I've messed up and can't figure out why the variable is not taken into account anymore 😃

@theofidry
Copy link
Collaborator

maybe we can just export it manually in the before_commands?

@Slamdunk
Copy link
Contributor Author

Mmm 😕

@Slamdunk
Copy link
Contributor Author

Ok, the first version of the configuration was good, PR ready to merge

@theofidry theofidry merged commit fe0776b into myclabs:2.x May 31, 2018
@theofidry
Copy link
Collaborator

Thanks very much!

@Slamdunk Slamdunk deleted the patch-2 branch May 31, 2018 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants