Improve mapper resource failure diagnostics - #1276
Draft
DragonFSKY wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResourcePatternResolver.getResources()before callingsetMapperLocations(...).Motivation
Issue #792 shows that passing the result of
getResource(...)for a wildcard location fails later whenSqlSessionFactoryBeanopens the resource. The existing catch block classified that I/O failure as an XML parse failure, so the exception did not explain how to correct the configuration.Following the maintainer guidance in #792, this change updates the exception at the actual I/O failure site rather than documenting an exception on the setter, which performs no I/O.
Implementation
try/catchblock and preserve the original cause.XMLMapperBuilderconstruction and parsing under the existing parse-failure diagnostic.ErrorContextreset behavior.Verification
./mvnw verifyBUILD SUCCESS— 226 tests, 0 failures, 0 errors, 15 skippedCloses #792