Skip to content

Update MapperMethodInvoker to public #3415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2025
Merged

Conversation

brucelwl
Copy link
Contributor

Copy link
Member

@harawata harawata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a new file MapperMethodInvoker.java in the org.apache.ibatis.binding package.

@brucelwl
Copy link
Contributor Author

brucelwl commented Feb 23, 2025

Please create a new file MapperMethodInvoker.java in the org.apache.ibatis.binding package.

@harawata done, please review and merge

@coveralls
Copy link

Coverage Status

coverage: 87.226%. remained the same
when pulling dd28727 on brucelwl:patch-1
into d8be9eb on mybatis:master.

@brucelwl brucelwl requested a review from harawata February 23, 2025 05:21
@harawata harawata merged commit ed55127 into mybatis:master Feb 23, 2025
19 checks passed
@harawata harawata self-assigned this Feb 23, 2025
@harawata harawata added this to the 3.6.x milestone Feb 23, 2025
@harawata
Copy link
Member

Merged.
Make sure not to create a vulnerable implementation.

@brucelwl
Copy link
Contributor Author

Can we also merge this code in version 3.5.20 ?

@harawata
Copy link
Member

Only critical issues will be fixed in 3.5.x, I think.

@brucelwl
Copy link
Contributor Author

This is a small change, If mybatis 3.6.x no longer supports Java8, I think it is still necessary to merge the code to version 3.5.x. If 3.6.x continues to support Java8, that would be acceptable

@harawata
Copy link
Member

This is a minor change that is irrelevant to most of the users, so no, we will not release 3.5.20 for this.
I hope you understand.

@brucelwl
Copy link
Contributor Author

I am not saying that release version 3.5.20 specifically for this small change, but I hope that this change can be carried when we release version 3.5.20 in the future

@harawata harawata removed this from the 3.6.x milestone Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants