Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add badges of CircleCI and codecov #62

Merged
merged 1 commit into from
Jul 7, 2019
Merged

Add badges of CircleCI and codecov #62

merged 1 commit into from
Jul 7, 2019

Conversation

my8100
Copy link
Owner

@my8100 my8100 commented Jul 7, 2019

No description provided.

@pep8speaks
Copy link

Hello @my8100! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 14:1: E266 too many leading '#' for block comment
Line 18:1: E266 too many leading '#' for block comment

@codecov
Copy link

codecov bot commented Jul 7, 2019

Codecov Report

Merging #62 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   89.46%   89.66%   +0.19%     
==========================================
  Files          30       30              
  Lines        3541     3541              
==========================================
+ Hits         3168     3175       +7     
+ Misses        373      366       -7
Impacted Files Coverage Δ
scrapydweb/default_settings.py 100% <ø> (ø) ⬆️
scrapydweb/__version__.py 100% <100%> (ø) ⬆️
scrapydweb/views/files/log.py 95.35% <0%> (+2.16%) ⬆️

@my8100 my8100 merged commit 071c3b3 into master Jul 7, 2019
@my8100 my8100 deleted the add_badges branch July 7, 2019 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants