Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TotalBytesSent and TotalBytesReceived #24

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Replace TotalBytesSent and TotalBytesReceived #24

merged 2 commits into from
Feb 8, 2021

Conversation

nachfuellbar
Copy link

replace both variables through the 64 byte ones
because the variables are formatted as a string there is an additional
change in fritzboxmetrics.go

replace both variables through the 64 byte ones
because the variables are formatted as a string there is an additional
change in fritzboxmetrics.go
pkg/fritzboxmetrics/fritzboxmetrics.go Outdated Show resolved Hide resolved
@mxschmitt
Copy link
Owner

Hi @nachfuellbar thanks for you contribution! Did you test it on your system? Then we can merge I think.

@nachfuellbar
Copy link
Author

Yep and it's working

btw the typo was copy and paste - you should replace the one some lines later too ;)

gateway_wan_bytes_receive_rate{gateway="fritz.box"} 5084
gateway_wan_bytes_received{gateway="fritz.box"} 1.9151830035e+10
gateway_wan_bytes_send_rate{gateway="fritz.box"} 6772
gateway_wan_bytes_sent{gateway="fritz.box"} 3.369153505e+09
gateway_wan_connection_status{gateway="fritz.box"} 1
gateway_wan_connection_uptime_seconds{gateway="fritz.box"} 70272
gateway_wan_layer1_downstream_max_bitrate{gateway="fritz.box"} 2.85305e+08
gateway_wan_layer1_link_status{gateway="fritz.box"} 1
gateway_wan_layer1_upstream_max_bitrate{gateway="fritz.box"} 4.441e+07
gateway_wan_packets_received{gateway="fritz.box"} 1.0456098e+07
gateway_wan_packets_sent{gateway="fritz.box"} 6.46255e+06

@mxschmitt
Copy link
Owner

Yep and it's working

btw the typo was copy and paste - you should replace the one some lines later too ;)

gateway_wan_bytes_receive_rate{gateway="fritz.box"} 5084
gateway_wan_bytes_received{gateway="fritz.box"} 1.9151830035e+10
gateway_wan_bytes_send_rate{gateway="fritz.box"} 6772
gateway_wan_bytes_sent{gateway="fritz.box"} 3.369153505e+09
gateway_wan_connection_status{gateway="fritz.box"} 1
gateway_wan_connection_uptime_seconds{gateway="fritz.box"} 70272
gateway_wan_layer1_downstream_max_bitrate{gateway="fritz.box"} 2.85305e+08
gateway_wan_layer1_link_status{gateway="fritz.box"} 1
gateway_wan_layer1_upstream_max_bitrate{gateway="fritz.box"} 4.441e+07
gateway_wan_packets_received{gateway="fritz.box"} 1.0456098e+07
gateway_wan_packets_sent{gateway="fritz.box"} 6.46255e+06

cool great! I currently unfortunately have no Fritz box anymore, so it's hard for me to bring this project forward. If you are interested in contributing to it, let me know!

@mxschmitt mxschmitt merged commit 2ae86fa into mxschmitt:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants