Bump github.com/golangci/golangci-lint from 1.28.1 to 1.31.0 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
…ctor (#977) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
OpenCensus go instrumentation uses 8 bytes array internally https://github.com/census-instrumentation/opencensus-go/blob/master/trace/export.go#L76, and before exporting it in OC format it's converted to a slice https://github.com/census-ecosystem/opencensus-go-exporter-ocagent/blob/master/transform_spans.go#L44. As a result root spans are exported with ParentSpanID set to 8 byte slices with all zero values. This commit make the OC->Internal trace convertor to skip those values and align it with internal representation of a root span which supposed to have ParentSpanID set to nil value instead.
* Add OTLP receiver docs * Also move hostmetrics docs here * Fix broken links * Other minor cleanup * Address feedback * Address feedback
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
…1003) * resourceprocessor: Don't panic when consumed resource has nil labels * Address feedback
Problem: If any zipkin span attribute that is used as source for setting OC status code (like status.code, http.status_code or census.status_code) received with a type other than int64, the underlying value will be taken as an integer. For example if http.status_code sent as "200" string attribute it's got converted to status code = 2. The problem wasn't that critical until we started setting error tag based on status code dmitryax/opentelemetry-collector@75ae919 This commit adds support of string values in status.code, http.status_code or census.status_code attributes and reject values of other types.
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
* Refactor common client TLS configuration. * Formatting and such * Add insecure options for test bed exporters * Fix logic in opencensus exporter * Add insecure flag to test configs * Rename object and simplify loading of gRPC Credentials
As is, the example k8s agent fails to deploy, going into a CrashLoopBackoff:
```
{"level":"info","ts":1589972770.1904275,"caller":"builder/exporters_builder.go:95","msg":"Exporter started.","component_kind":"exporter","component_type":"otlp","component_name":"otlp"}
Error: cannot setup pipelines: cannot build pipelines: error creating processor "memory_limiter" in pipeline "traces": checkInterval must be greater than zero
2020/05/20 11:06:10 Application run finished with error: cannot setup pipelines: cannot build pipelines: error creating processor "memory_limiter" in pipeline "traces": checkInterval must be greater than zero
```
Testing:
I created a completely empty minikube and tried to apply k8s.yml from master. With this change, the agent becomes ready.
Documentation
None - caveat: as I couldn't find existing documentation for checkInterval and am just playing around right now, I don' really know if 5s is a sensible value for this.
…n provided context's cancelFn to signal end of ticker (#1017)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
This was removed before but found its way back in. I'm hoping keeping it included with // indirect but changing it to pin to sha1 will prevent it from getting clobbered again. Added note explaining why it's pinned the way it is.
Resolves: jaegertracing/jaeger#2252 Related to open-telemetry/opentelemetry-collector#294 Just fixing the log message. The warn level was printing stacktrace what was confusing for users.
1. PICT tool input files for trace data and resulting output files from running pict from the command line. These are in `internal/goldendataset/testdata`. See: [Pairwise Independent Combinatorial Testing](https://github.com/microsoft/pict) 2. Generator for fully-populated OLTP ResourceSpans from PICT output files. This has all the intended functionality for this PR. It has no impact on other functionality so there should be no problem in merging to master. I will follow up with other PRs to complete full "Golden Dataset" testing functionality. **Link to tracking Issue:** #652 **Testing:** Unit tests exist for all functionality which has been coded so far **Documentation:** None yet. Will do so after golden dataset generation coding is complete.
This change adds application/x-protobuf support to the existing grpc-gateway mux in the OTLP receiver. See: https://github.com/open-telemetry/oteps/blob/master/text/0099-otlp-http.md What currently works: * The receiver will correctly process HTTP requests with the Content-Type application/x-protobuf. * The receiver will respond with Content-Type application/x-protobuf. * The receiver will respond with status code HTTP 200 OK on success. What doesn't work yet: * The receiver cannot handle gzip-encoded requests (Content-Encoding gzip). * The receiver will not gzip-encode responses to requests with Accept-Encoding: gzip. Updates #881
The goal is to understand who is using the OpenTelemetry Collector in production. Other CNCF projects have taken a similar approach to highlight adoption.
* Initial commit of host metrics virtual memory scraper for windows * Added non-windows virtual memory scraper implementation
- Removed the draft logsproto and now using the logs Protobufs from official OTLP repo. The rest of the changes are forced by this. - Added InstrumentationLibraryLogs and change the type of LogRecord.Body to AnyValue. - Updated fileexporter and logexporter to use the new log data type.
* Add release documentation * fix formatting
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.13.0 to 1.15.0. - [Release notes](https://github.com/uber-go/zap/releases) - [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md) - [Commits](uber-go/zap@v1.13.0...v1.15.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/ory/go-acc](https://github.com/ory/go-acc) from 0.2.1 to 0.2.5. - [Release notes](https://github.com/ory/go-acc/releases) - [Commits](ory/go-acc@v0.2.1...v0.2.5) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add support for queued retry in the exporter helper. Changed only the OTLP exporter for the moment to use the new settings. Timeout is enabled for all the exporters. Fixes #1193 There are some missing features that will be added in a followup PR: 1. Enforcing errors. For the moment added the Throttle error as a hack to keep backwards compatibility with OTLP. 2. Enable queued and retry for all exporters. 3. Fix observability metrics for the case when requests are dropped because the queue is full. * First round of comments addressed
* Add a utility to generate metric data for testing * Address feedback * Address feedback
…ter (#1400) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Bumps [go.opencensus.io](https://github.com/census-instrumentation/opencensus-go) from 0.22.3 to 0.22.4. - [Release notes](https://github.com/census-instrumentation/opencensus-go/releases) - [Commits](census-instrumentation/opencensus-go@v0.22.3...v0.22.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This can receive logs in the [Fluent Forward Protocol](https://github.com/fluent/fluentd/wiki/Forward-Protocol-Specification-v1) via either TCP or Unix sockets. It supports all of the required features of the spec. It currently does not support the optional handshake aspect of the protocol, but will acknowledge chunk options per the spec. All log entries received within a short time window of each other will be put into the same ResourceLog instance before being emitted to the next consumer in the pipline. The Resource object is currently not populated in any way.
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Need to wrap metric before sending out from resource processor, wrapping was lost during this change open-telemetry/opentelemetry-collector@afc4796
* Add batch size bytes metrics Signed-off-by: Pavol Loffay <ploffay@redhat.com> * increase test coverage Signed-off-by: Pavol Loffay <ploffay@redhat.com> * Fix metrics Signed-off-by: Pavol Loffay <ploffay@redhat.com> * Fix test Signed-off-by: Pavol Loffay <ploffay@redhat.com> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.28.1 to 1.31.0. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.28.1...v1.31.0) Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/go_modules/github.com/golangci/golangci-lint-1.31.0
branch
mxiamxia
pushed a commit
that referenced
this pull request
Oct 7, 2020
* Add DataDog exporter back from old fork
commit 99129fb96e29e9c1a92da00b7e3f8efcae8a31e8
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Thu Sep 3 18:10:28 2020 +0200
Handle namespace at initialization time
commit babca25927926a60c0c416294af3aadf784d41b9
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Thu Sep 3 17:23:53 2020 +0200
Initialize on a separate function
This way the variables can be checked without worrying about the env
commit 24d0cb4cc566fa5313a8650c904a27bea68bf555
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Thu Sep 3 14:30:35 2020 +0200
Check environment variables for unified service tagging
commit 6695f8297ab8b1fcae71b05acb027c4a0992e3a0
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Wed Sep 2 14:57:37 2020 +0200
Add support for sending metrics through the API
- Use datadog.Metric type for simplicity
- Get host if unset
commit c366603
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Wed Sep 2 09:56:24 2020 +0200
Disable Queue and Retry settings (#72)
These are handled by the statsd package.
OpenTelemetry docs are confusing and the default configuration (disabled)
is different from the one returned by "GetDefault..." functions
commit a660b56
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Tue Sep 1 15:26:14 2020 +0200
Add support for summary and distribution metric types (#65)
* Add support for summary metric type
* Add support for distribution metrics
* Refactor metrics construction
- Drop name in Metrics (now they act as Metric values)
- Refactor constructor so that errors happen at compile-time
* Report Summary total sum and count values
Snapshot values are not filled in by OpenTelemetry
* Report p00 and p100 as `.min` and `.max`
This is more similar to what we do for our own non-additive type
* Keep hostname if it has not been overridden
commit c95adc4
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Thu Aug 27 13:00:02 2020 +0200
Update dependencies and `make gofmt`
The collector was updated to 0.9.0 upstream
commit 20afb0e
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Wed Aug 26 18:25:49 2020 +0200
Refactor configuration (#45)
* Refactor configuration
* Implement telemetry and tags configuration handling
* Update example configuration and README file
Co-authored-by: Kylian Serrania <kylian.serrania@datadoghq.com>
commit fdc98b5
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Fri Aug 21 11:09:08 2020 +0200
Initial DogStatsD implementation (#15)
Initial metrics exporter through DogStatsD with support for all metric types but summary and distribution
commit e848a60
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Fri Aug 21 10:42:45 2020 +0200
Bump collector version
commit 58be9a4
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Thu Aug 6 10:04:32 2020 +0200
Address linter
commit 695430c
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Tue Aug 4 13:28:01 2020 +0200
Fix field name error
MetricsEndpoint was renamed to MetricsURL
commit 168b319
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Mon Aug 3 11:05:01 2020 +0200
Create initial outline for Datadog exporter (#1)
* Add support for basic configuration options
* Documents configuration options
* go mod tidy
* Address feedback from upstream PR we did not merge (#1)
* Backport changes from upstream PR
Remove `err` from MapMetrics
* Remove usage of pdatautil
* Fix tests
* Use TCPAddr
* Review which functions should be private
* Remove DogStatsD mode (#2)
* Remove DogStatsD mode
* go mod tidy
* Remove mentions to DogStatSD
* Improve test coverage (#3)
* Improve test coverage
Added unit tests for
- API key censoring
- Hostname
- Metrics exporter
Renamed test and implementation files for consistency
* Add one additional test
* Remove client validation (#6)
The zorkian API does not validate the API key unless you also have
an application key, even though the endpoint works without it.
I am removing this validation until this gets fixed on the zorkian library
* Keep only configuration and factory methods
Following the contribution guidelines we need to make a first PR
with this
* Use latest version of collector
* Remove `report_percentiles` option
It is not being used as of now until the OTLP metrics format
stabilizes and we have a Summary type metric again
* Correct configuration
The API key is now a required setting
* Remove test not relevant for this PR
* Remove unnecessary imports after removing test
* Address review comment
* Apply suggestions from code review
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
* Separate documentation into two examples
One example with the minimal configuration, for sending to `datadoghq.com`
and a second one for sending to `datadoghq.eu`
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
mxiamxia
pushed a commit
that referenced
this pull request
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/golangci/golangci-lint from 1.28.1 to 1.31.0.
Release notes
Sourced from github.com/golangci/golangci-lint's releases.
... (truncated)
Commits
3d6d0e7Prepare v1.31.0 (#1356)2cb7515update exhaustive linter (#1339)95cb484build(deps): bump gatsby-plugin-sitemap from 2.4.11 to 2.4.12 in /docs (#1344)63e28ecbuild(deps): bump gatsby-remark-images from 3.3.25 to 3.3.28 in /docs (#1345)52dc198build(deps): bump polished from 3.6.5 to 3.6.6 in /docs (#1347)3ca396ebuild(deps): bump github.com/sourcegraph/go-diff from 0.5.3 to 0.6.0 (#1353)fdfad7bbuild(deps): bump gatsby-plugin-manifest from 2.4.23 to 2.4.27 in /docs (#1355)74d13f9build(deps): bump gatsby-plugin-sharp from 2.6.25 to 2.6.31 in /docs (#1354)ee85322Fix typo in performance docs (#1350)ca8bbb8build(deps): bump gatsby from 2.24.37 to 2.24.52 in /docs (#1342)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)