feat: remove hard-coded paths on AccessorProxyGenerator#233
Open
bruno-martins-mx wants to merge 1 commit intomasterfrom
Open
feat: remove hard-coded paths on AccessorProxyGenerator#233bruno-martins-mx wants to merge 1 commit intomasterfrom
bruno-martins-mx wants to merge 1 commit intomasterfrom
Conversation
bruno-martins-mx
force-pushed
the
bm/mc-4457
branch
from
1a4c5c4 to
80c924c
Compare
mattnichols
reviewed
Jan 29, 2025
Collaborator
|
Does this need to be rebased? There are changes that are not related to the goal of the PR. ?? |
bruno-martins-mx
force-pushed
the
bm/mc-4457
branch
from
80c924c to
27ec637
Compare
Contributor
Author
Yes, thanks for pointing it out! Problem should be fixed now. |
meotch
approved these changes
Feb 7, 2025
Contributor
meotch
left a comment
meotch
left a comment
There was a problem hiding this comment.
@mattnichols do you have any remaining concerns with this MR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Remove hard-coded paths on
AccessorProxyGenerator.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: