Export Icon Paths #809
Merged
Export Icon Paths #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
cerinman
added a commit
that referenced
this pull request
Nov 15, 2018
* Remove global handler prop to ListBox in SimpleSelect and Select. (#802) * Remove global handler prop to ListBox in SimpleSelect and Select. * Update change log for recent change. * Sb/jmo/separate packages (#813) * update travis * add bundle size * add bundlesize package * fix bundle check * remove bundlesize from travis * remove docs:build * remove build * fix bundle output * retry bundle size * test uncompressed bundle size * bump version * Docs Version: undefined * reset gitignore * clean up package * fix version * remove bundle * Docs Version: 6.1.3 * Update docs package and lock file. * Update main lib package and lock file. * Get bundle size into the package.jsons. * Update travis.yml to change build process. * Update lock file * Export Icon Paths (#809) * Creates new IconPaths constant * Replace swith statement with new IconPaths constant * Export IconPaths constant * fix export issues * Name export better * export helper IconPaths as an object * Fix change log * Docs Version: 6.1.3 * Bumping maxSize to 3.37 * npm audit fix * npm audit fix docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the icon paths used in the
Iconcomponent out to a constant file with a helper function for getting the correct path.I've done this because I have a need to access the path data internally for a new budget icon based upon path data used here in the
Iconcomponent.I've had to use function here because we recently added path data to be used with a backgroundFillColor prop so that we can color the background of some icons.