Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency on mock #285

Merged
merged 7 commits into from
Jul 9, 2019
Merged

Remove the dependency on mock #285

merged 7 commits into from
Jul 9, 2019

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Jul 9, 2019

In Python 3, mock is available in base Python as unittest.mock. See #279

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #285 into master will decrease coverage by 1.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #285     +/-   ##
=========================================
- Coverage    99.2%   98.01%   -1.2%     
=========================================
  Files          68       69      +1     
  Lines        6667     6644     -23     
=========================================
- Hits         6614     6512    -102     
- Misses         53      132     +79
Impacted Files Coverage Δ
tests/test_cli.py 97.73% <100%> (-2.27%) ⬇️
tests/test_escape_magics.py 100% <100%> (ø) ⬆️
jupytext/contentsmanager.py 98.45% <100%> (ø) ⬆️
tests/test_header.py 100% <100%> (ø) ⬆️
tests/test_active_cells.py 100% <100%> (ø) ⬆️
tests/test_read_simple_markdown.py 100% <100%> (ø) ⬆️
tests/test_load_multiple.py 100% <100%> (ø) ⬆️
tests/test_trust_notebook.py 100% <100%> (ø) ⬆️
tests/test_rmd_to_ipynb.py 100% <100%> (ø) ⬆️
tests/test_mirror.py 98.96% <100%> (-1.04%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc11f22...c02ee2f. Read the comment docs.

As conditional requirements are not compatible with conda and break our CI
@mwouts mwouts merged commit b989f4f into master Jul 9, 2019
@mwouts mwouts deleted the removed_mock branch July 9, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants