Skip to content

Add a test to make sure that rename_file does not open it #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Apr 19, 2025

Relates to #1376

Copy link

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

HATCH_BUILD_HOOKS_ENABLE=true pip install git+https://github.com/mwouts/jupytext.git@check_rename_does_not_open_file_issue_1376

(this requires nodejs, see more at Developing Jupytext)

Copy link

codecov bot commented Apr 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (518ab60) to head (c27088b).

❌ Your project status has failed because the head coverage (96.77%) is below the target coverage (97.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1377      +/-   ##
==========================================
- Coverage   96.87%   96.81%   -0.07%     
==========================================
  Files          32       32              
  Lines        4989     4989              
==========================================
- Hits         4833     4830       -3     
- Misses        156      159       +3     
Flag Coverage Δ
external 73.40% <ø> (+0.16%) ⬆️
functional 87.35% <ø> (ø)
integration 80.60% <ø> (ø)
unit 65.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwouts
Copy link
Owner Author

mwouts commented Apr 26, 2025

Closing as this test did not spot the problem.

@mwouts mwouts closed this Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant