Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo #1253

Merged
merged 2 commits into from
Jun 30, 2024
Merged

Fix a typo #1253

merged 2 commits into from
Jun 30, 2024

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Jun 30, 2024

when build_jupytext_contents_manager_class can't be imported, we
define it as a class that re-raise the exception that was encountered.

Relates to #1162

Copy link

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

HATCH_BUILD_HOOKS_ENABLE=true pip install git+https://github.com/mwouts/jupytext.git@fix_typo_1162

(this requires nodejs, see more at Developing Jupytext)

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (42a48e8) to head (28f33e0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1253   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files          29       29           
  Lines        4468     4468           
=======================================
  Hits         4367     4367           
  Misses        101      101           
Flag Coverage Δ
external 75.14% <ø> (+0.09%) ⬆️
functional 88.52% <ø> (ø)
integration 77.28% <ø> (ø)
unit 66.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwouts mwouts merged commit 4e95b2c into main Jun 30, 2024
3 checks passed
@mwouts mwouts deleted the fix_typo_1162 branch June 30, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant