Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the standard lib tomllib, or default to tomli if not available #1200

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Jan 9, 2024

Closes #1195

Copy link

github-actions bot commented Jan 9, 2024

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

pip install git+https://github.com/mwouts/jupytext.git@use_tomllib_or_tomli

(this requires nodejs, see more at Developing Jupytext)

@mwouts mwouts force-pushed the use_tomllib_or_tomli branch 3 times, most recently from 13f98cc to 78b0e65 Compare January 9, 2024 22:12
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (642c709) to head (e9c56ab).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1200   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files          29       29           
  Lines        4463     4464    +1     
=======================================
+ Hits         4362     4363    +1     
  Misses        101      101           
Flag Coverage Δ
external 75.17% <75.00%> (+0.14%) ⬆️
functional 88.51% <75.00%> (+0.02%) ⬆️
integration 77.28% <100.00%> (+<0.01%) ⬆️
unit 66.56% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwouts mwouts added this to the 1.16.2 milestone Apr 27, 2024
@mwouts mwouts merged commit fe2ba5e into main Apr 28, 2024
30 of 32 checks passed
@mwouts mwouts deleted the use_tomllib_or_tomli branch April 28, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace toml package with tomli
2 participants