Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indented python code in .py file should not be split into multiple cells #20

Closed
mwouts opened this issue Jul 19, 2018 · 1 comment
Closed

Indented python code in .py file should not be split into multiple cells #20

mwouts opened this issue Jul 19, 2018 · 1 comment
Assignees
@mwouts

Comments

@mwouts
Copy link
Owner

mwouts commented Jul 19, 2018

Currently the criterion for end of python cell is 'two blank lines'.

For non pep8 files, this can break a python function into two cells.
We could use indentation to detect when a cell actually ends, and make sure that that f in the example below is parsed as a single cell:

def f(a):


    return a+1
@mwouts mwouts self-assigned this Jul 19, 2018
@mwouts mwouts changed the title Indented python code in .py file should not be breaked into multiple cells Indented python code in .py file should not be split into multiple cells Jul 19, 2018
mwouts added a commit that referenced this issue Jul 19, 2018
@mwouts
Indented code cannot start a python cell #20
b051851
@mwouts
Copy link
Owner Author

mwouts commented Jul 19, 2018

Fixed in v0.4.1

@mwouts mwouts closed this as completed Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwouts mwouts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mwouts