Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing all notebook metadata to py:percent #196

Closed
phaustin opened this issue Mar 4, 2019 · 5 comments
Closed

passing all notebook metadata to py:percent #196

phaustin opened this issue Mar 4, 2019 · 5 comments

Comments

@phaustin
Copy link
Contributor

phaustin commented Mar 4, 2019

I'm trying to pass top-level notebook metadata by setting the metadata filter to "all"

https://github.com/phaustin/jupytext_metadata_issue/blob/master/test_metadata_filter.py#L11

but the extra metadata is stripped and this assert fails:

https://github.com/phaustin/jupytext_metadata_issue/blob/master/test_metadata_filter.py#L31

Is the there a flag I'm missing?

thanks, Phil

@mwouts
Copy link
Owner

mwouts commented Mar 5, 2019

Hello @phaustin , well this should have worked. I briefly gave a try on another example, and it did not work neither. Apparently the all filter for notebook metadata is not correctly implemented (I will have a look at this next week).

@mwouts
Copy link
Owner

mwouts commented Mar 5, 2019

Until then, do you want to set "notebook_metadata_filter": "base_numbering" ? That would add base_numbering to the notebook metadata (i.e. jupytext and kernelspec by default) in the text representation of the notebook.

@phaustin
Copy link
Contributor Author

phaustin commented Mar 5, 2019

no hurry on my end, I'm fine with hand editing notebooks for this course for now, and I can always write a postprocessing hook

mwouts added a commit that referenced this issue Mar 12, 2019
@mwouts mwouts mentioned this issue Mar 13, 2019
@mwouts mwouts closed this as completed in cd4cc48 Mar 13, 2019
@mwouts
Copy link
Owner

mwouts commented Mar 13, 2019

@phaustin , the fix is available in version 1.0.3. Can you please confirm that it works as intended? Thanks.

@phaustin
Copy link
Contributor Author

works for me, thanks, Phil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants