Skip to content

Conversation

@mwouts
Copy link
Owner

@mwouts mwouts commented Dec 21, 2025

Closes #471

TODO:

  • Remove the additional string added to the "enum" types
  • Get a proper formatting for pl.DataFrame({"float": [math.pi, math.pi * 1e12]}) (get 3.1416e12 for the second row, not 3141600000000 as currently)

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2025

Codecov Report

❌ Patch coverage is 96.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.85%. Comparing base (3dc4eb4) to head (824ef99).

Files with missing lines Patch % Lines
src/itables/datatables_format.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
+ Coverage   93.83%   93.85%   +0.02%     
==========================================
  Files          46       46              
  Lines        2367     2409      +42     
==========================================
+ Hits         2221     2261      +40     
- Misses        146      148       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Dec 21, 2025

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab.

Also, the version of ITables developed in this PR is available as a wheel artifact 📦 for easy installation.
Download it here, unzip it and then run pip install itables-xxx.whl in the unzipped directory.

A conda package is also available for easy installation:
Download it here, and then run conda install itables-xxx.tar.bz2 in the directory where you downloaded the file.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@mwouts
Copy link
Owner Author

mwouts commented Dec 30, 2025

There is currently no public function that one can use instead of ._s.get_fmt, cf. pola-rs/polars#25880. I'll give another try at the str conversion for complex types, and possibly use ._s.get_fmt with a safety fallback if it was bound to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply the Polars formatting (e.g. floating point precision) to column of types array[f64] or list[f64]

3 participants