Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interact.js #93

Merged
merged 1 commit into from
Nov 29, 2016
Merged

Conversation

knqyf263
Copy link

Doorman displays the following error in /manage/rules/add.

query-builder.standalone.js:2943 Uncaught Error: interact.js is required to use "sortable" plugin. Get it here: http://interactjs.io

This is because jQuery-QueryBuilder implemented interact.js
mistic100/jQuery-QueryBuilder@221eb4f#diff-d23309cd66d33b4200455ba8287dbca4R11

I sent Pull Request to jQuery-QueryBuilder to move interact from devDependencies to dependencies.
mistic100/jQuery-QueryBuilder#396

I received the following answer

I put it in dev dependencies because it's not a required component for the basic use of the library, it's the same for every dependency of query builder plugins.

So, I think that Doorman should add interact.js to devendencies.
How about this proposal?

At least, if I don't install interact.js, I get an error.
Please tell me if there is any other good way.
Thanks!

@mwielgoszewski
Copy link
Owner

Hi @knqyf263 - this is great! Thanks for keeping track of such developments by third-party libraries we use, and submitting a PR to address when things would break.

@mwielgoszewski mwielgoszewski merged commit be8209c into mwielgoszewski:master Nov 29, 2016
@knqyf263
Copy link
Author

You're welcome!
Doorman is a useful tool, so I want you to keep doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants