Send a notification when a node enrolls for the first time #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwielgoszewski
force-pushed
the
notify-on-enroll
branch
from
ebcc848 to
636e723
Compare
|
Fixes #68 |
mwielgoszewski
force-pushed
the
notify-on-enroll
branch
from
636e723 to
2d31324
Compare
mwielgoszewski
added a commit
that referenced
this pull request
Aug 17, 2017
This commit undoes a lot of the work done in #112, and allows us to reuse our existing rule manager and alerting infrastructure to also alert when a new node is enrolled, rather than having to call a specific method to get this functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some much needed notifications to alert us when a new node comes online.