Fix bug with partial initialization of a decrypted private key in open SSH format #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…was in the open ssh format - ep_array and eq_array were not initialized and it was impossible to obtain a private key byte array because of NullPointerException on attempt to read these arrays length. Not sure if it is possible to read these arrays from the Buffer, but it seems the same approach as for putty & fsecure keys also works fine.
orybak
pushed a commit
to JetBrains/teamcity-git
that referenced
this pull request
Jul 29, 2021
|
I would have to defer to @mwiede as I'm not as familiar with the various ssh key file formats. |
mwiede
added a commit
that referenced
this pull request
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to decrypt an RSA key stored in an encrypted form in an OpenSSH format and then fetch private key throws an exception:
Exception in thread "main" java.lang.NullPointerException
at com.jcraft.jsch.KeyPairRSA.getPrivateKey(KeyPairRSA.java:105)
This happens because ep_array and eq_array are not initialized when KeyPairRSA is created.