Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.0 changes #113

Merged
merged 22 commits into from
Feb 9, 2022
Merged

0.2.0 changes #113

merged 22 commits into from
Feb 9, 2022

Conversation

norrisjeremy
Copy link
Contributor

@norrisjeremy norrisjeremy commented Jan 21, 2022

  • Disable RSA/SHA1 signature algorithm by default Disable ssh-rsa (RSA/SHA1) signature scheme by default #75.
  • Add basic Logger implementations.
  • Fix client version to be compliant with RFC 4253 section 4.2 by not including minus sign characters Can't connect to azure blob storage using jsch #115.
  • Add java.util.zip based compression implementation Replace JZlib by JRE Deflater/Inflater #114.
  • Remove deprecated oss-parent oss-parent deprecated? #116.
  • Use flatten-maven-plugin to produce flattened POM.
  • Add JZlib & jBCrypt licenses to POM.
  • Include license files in jar file.
  • Use maven-assembly-plugin to build sources jar instead of maven-sources-plugin so that Java 9+ sources are includes as well as licenses.
  • Only include com.jcraft.jsch package in Javadocs, include Java 9+ sources and reduce verbosity.
  • Use Class.asSubclass() method to avoid instantiating an object that isn't descended from the expected interface.
  • Follow OpenSSH's lead for skipping packet discard logic when using EtM MACs and also adjust discard lengths to match OpenSSH.

@norrisjeremy norrisjeremy changed the title Disable RSA/SHA1 signature algorithm by default 0.2.0 changes Feb 2, 2022
@norrisjeremy norrisjeremy force-pushed the 20220121 branch 7 times, most recently from 66ff104 to c11ec1b Compare February 5, 2022 08:50
@mwiede
Copy link
Owner

mwiede commented Feb 7, 2022

Hey @norrisjeremy I am looking through the PR tomorrow

@norrisjeremy
Copy link
Contributor Author

Hi @mwiede,

Great, thanks! Let me know if there are any other changes needed to make your release process work with the removal of oss-parent from the POM.

Thanks,
Jeremy

…M MACs and also adjust discard lengths to match OpenSSH.
@mwiede mwiede mentioned this pull request Feb 9, 2022
@mwiede mwiede merged commit 54f2d02 into mwiede:master Feb 9, 2022
@norrisjeremy
Copy link
Contributor Author

FYI, I have an additional change incoming shortly.

@mwiede
Copy link
Owner

mwiede commented Feb 9, 2022

alright, i am waiting with the release

@norrisjeremy
Copy link
Contributor Author

Okie, running one last set of ITs locally, then I'll push a new PR.

Btw, I noticed that you attempted to run release workflow but it didn't work? I'm guessing it's related to the changes I made to remove oss-parent? Do you need assistance to figure out what went wrong?

@norrisjeremy
Copy link
Contributor Author

See #121.

@mwiede
Copy link
Owner

mwiede commented Feb 9, 2022

Okie, running one last set of ITs locally, then I'll push a new PR.

Btw, I noticed that you attempted to run release workflow but it didn't work? I'm guessing it's related to the changes I made to remove oss-parent? Do you need assistance to figure out what went wrong?

It was the authentication against the sonatype server. I already changed the secret configuration, so it should be fixed with the next one.

@norrisjeremy norrisjeremy deleted the 20220121 branch February 9, 2022 11:52
@norrisjeremy
Copy link
Contributor Author

Okie, sounds good!

Just curious as to the POM changes in 154d1ee? What sort of issues were you encountering?

@mwiede
Copy link
Owner

mwiede commented Feb 10, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants