-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.2.0 changes #113
0.2.0 changes #113
Conversation
norrisjeremy
commented
Jan 21, 2022
•
edited
Loading
edited
- Disable RSA/SHA1 signature algorithm by default Disable ssh-rsa (RSA/SHA1) signature scheme by default #75.
- Add basic Logger implementations.
- Fix client version to be compliant with RFC 4253 section 4.2 by not including minus sign characters Can't connect to azure blob storage using jsch #115.
- Add java.util.zip based compression implementation Replace JZlib by JRE Deflater/Inflater #114.
- Remove deprecated oss-parent oss-parent deprecated? #116.
- Use flatten-maven-plugin to produce flattened POM.
- Add JZlib & jBCrypt licenses to POM.
- Include license files in jar file.
- Use maven-assembly-plugin to build sources jar instead of maven-sources-plugin so that Java 9+ sources are includes as well as licenses.
- Only include com.jcraft.jsch package in Javadocs, include Java 9+ sources and reduce verbosity.
- Use Class.asSubclass() method to avoid instantiating an object that isn't descended from the expected interface.
- Follow OpenSSH's lead for skipping packet discard logic when using EtM MACs and also adjust discard lengths to match OpenSSH.
…ncluding minus sign characters mwiede#115.
66ff104
to
c11ec1b
Compare
c11ec1b
to
3c91145
Compare
…es-plugin so that Java 9+ sources are includes as well as licenses.
…rces and reduce verbosity.
3c91145
to
3c35389
Compare
…sn't descended from the expected interface.
Hey @norrisjeremy I am looking through the PR tomorrow |
Hi @mwiede, Great, thanks! Let me know if there are any other changes needed to make your release process work with the removal of Thanks, |
…M MACs and also adjust discard lengths to match OpenSSH.
FYI, I have an additional change incoming shortly. |
alright, i am waiting with the release |
Okie, running one last set of ITs locally, then I'll push a new PR. Btw, I noticed that you attempted to run release workflow but it didn't work? I'm guessing it's related to the changes I made to remove oss-parent? Do you need assistance to figure out what went wrong? |
See #121. |
It was the authentication against the sonatype server. I already changed the secret configuration, so it should be fixed with the next one. |
Okie, sounds good! Just curious as to the POM changes in 154d1ee? What sort of issues were you encountering? |
no issues per se. I am using this in most of my projects. I find it useful,
because it removes the "conflicts" between transitive dependencies, which
are shown in my "maven helper" plugin in Intellij.
…On Wed, Feb 9, 2022 at 12:54 PM Jeremy Norris ***@***.***> wrote:
Okie, sounds good!
Just curious as to the POM changes in 154d1ee
<154d1ee>?
What sort of issues were you encountering?
—
Reply to this email directly, view it on GitHub
<#113 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAL6NOE77H4TXCCDAYIZ2H3U2JIWTANCNFSM5MP7GZLQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|