Skip to content

Fixed stack overflow issue in the tests #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwhelan merged 1 commit into from
Jun 29, 2016
Merged

Fixed stack overflow issue in the tests #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 35 additions & 35 deletions src/TestStack.BDDfy.Tests/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,42 +1,42 @@
{
"version": "1.0.0-*",
"testRunner": "xunit",
"version": "1.0.0-*",
"testRunner": "xunit",

"dependencies": {
"Shouldly": "2.8.0",
"TestStack.BDDfy": {
"target": "project"
"dependencies": {
"Shouldly": "2.8.0",
"TestStack.BDDfy": {
"target": "project"
},
"Microsoft.NETCore.Platforms": "1.0.1",
"xunit.core": "2.2.0-beta2-build3300",
"dotnet-test-xunit": "2.2.0-preview2-build1029"
},
"Microsoft.NETCore.Platforms": "1.0.1",
"xunit.core": "2.2.0-beta2-build3300",
"dotnet-test-xunit": "2.2.0-preview2-build1029"
},

"runtimes": {
"win10-x64": {}
},

"frameworks": {
"netcoreapp1.0": {
"dependencies": {
"Microsoft.NETCore.App": "1.0.0"
},
"imports": [
"dnxcore50",
"portable-net45+win8"
]
"runtimes": {
"win10-x64": { }
},
"net46": {
"dependencies": {
"NSubstitute": "1.10.0"
},
"buildOptions": {
"define": [
"Approvals",
"Culture",
"NSubstitute"
]
}

"frameworks": {
"netcoreapp1.0": {
"dependencies": {
"Microsoft.NETCore.App": "1.0.0"
},
"imports": [
"dnxcore50",
"portable-net45+win8"
]
},
"net46": {
"dependencies": {
"NSubstitute": "1.10.0"
},
"buildOptions": {
"define": [
"Approvals",
"Culture",
"NSubstitute"
]
}
}
}
}
}
6 changes: 5 additions & 1 deletion src/TestStack.BDDfy/TypeExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ public static bool IsValueType(this Type type)
}

#else
using System.Linq;
public static class TypeExtensions
{
public static Assembly Assembly(this Type type)
Expand All @@ -48,7 +49,10 @@ public static Assembly Assembly(this Type type)

public static object[] GetCustomAttributes(this Type type, Type attributeType, bool inherit)
{
return type.GetCustomAttributes(attributeType, inherit);
return type.GetTypeInfo()
.GetCustomAttributes(attributeType, inherit)
.Cast<object>()
.ToArray();
}

public static bool IsEnum(this Type type)
Expand Down
26 changes: 13 additions & 13 deletions src/TestStack.BDDfy/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
"buildOptions": {
"embed": "**/Scripts/*.*"
},
"dependencies": {
"NETStandard.Library": "1.6.0",
"Newtonsoft.Json": "9.0.1"
},
"dependencies": {
"NETStandard.Library": "1.6.0",
"Newtonsoft.Json": "9.0.1"
},

"frameworks": {
"net40": {
Expand All @@ -29,15 +29,15 @@
},
"netstandard1.5": {
"imports": "dnxcore50",
"dependencies": {
"System.Reflection.TypeExtensions": "4.1.0",
"System.Runtime.Loader": "4.0.0",
"System.Threading.ThreadPool": "4.0.10",
"System.Linq.Expressions": "4.1.0",
"System.Reflection": "4.1.0",
"System.Runtime.Extensions": "4.1.0",
"System.Diagnostics.StackTrace": "4.0.1"
}
"dependencies": {
"System.Reflection.TypeExtensions": "4.1.0",
"System.Runtime.Loader": "4.0.0",
"System.Threading.ThreadPool": "4.0.10",
"System.Linq.Expressions": "4.1.0",
"System.Reflection": "4.1.0",
"System.Runtime.Extensions": "4.1.0",
"System.Diagnostics.StackTrace": "4.0.1"
}
}
}
}