Skip to content

Not compatible with nodejs 10.x LTS #5

@tobyee

Description

@tobyee

Issue Description

Error messages shows as follow when run mxgit command by Node.js 10.x. (Lower version works fine)

mxgit: using Mendix-App-xxx.mpr (project dir: ./)
mxgit: initializing SVN dummy repository...
fs.js:128
  throw new ERR_INVALID_CALLBACK();
  ^

TypeError [ERR_INVALID_CALLBACK]: Callback must be a function
    at maybeCallback (fs.js:128:9)
    at Object.exists (fs.js:196:3)
    at Object.copySync (D:\fix\mxgit\node_modules\fs-extra\lib\copy.js:62:23)
    at initializeSvnDir (D:\fix\mxgit\mxgit.js:314:6)
    at next (D:\fix\mxgit\mxgit.js:685:4)
    at D:\fix\mxgit\mxgit.js:693:6
    at checkSvnDir (D:\fix\mxgit\mxgit.js:307:3)
    at next (D:\fix\mxgit\mxgit.js:685:4)
    at D:\fix\mxgit\mxgit.js:693:6
    at D:\fix\mxgit\mxgit.js:758:3

Trouble Shoot

Node.js 10.x API fs.exits require a callback function otherwise it will throw an exception. The version of fs-extra depended by mxgit have a bug that should use fs.existsSync instead of fs.exists in method fs.copySync, see the this commit jprichardson/node-fs-extra@1a71665. So we need to upgrade module fs-extra from 0.8.1 to 0.13.0 at least to fixed the compatibility problem.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions