Skip to content

Commit

Permalink
Remove modbus codeowner, and downgrade to quality "No score" (home-as…
Browse files Browse the repository at this point in the history
…sistant#122010)

Co-authored-by: Franck Nijhof <git@frenck.dev>
  • Loading branch information
janiversen and frenck authored Jul 16, 2024
1 parent 22d977a commit bc7d2d2
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 8 deletions.
2 changes: 0 additions & 2 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -884,8 +884,6 @@ build.json @home-assistant/supervisor
/tests/components/moat/ @bdraco
/homeassistant/components/mobile_app/ @home-assistant/core
/tests/components/mobile_app/ @home-assistant/core
/homeassistant/components/modbus/ @janiversen
/tests/components/modbus/ @janiversen
/homeassistant/components/modem_callerid/ @tkdrob
/tests/components/modem_callerid/ @tkdrob
/homeassistant/components/modern_forms/ @wonderslug
Expand Down
4 changes: 2 additions & 2 deletions homeassistant/components/modbus/manifest.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"domain": "modbus",
"name": "Modbus",
"codeowners": ["@janiversen"],
"codeowners": [],
"documentation": "https://www.home-assistant.io/integrations/modbus",
"iot_class": "local_polling",
"loggers": ["pymodbus"],
"quality_scale": "platinum",
"quality_scale": "silver",
"requirements": ["pymodbus==3.6.9"]
}
4 changes: 0 additions & 4 deletions script/hassfest/manifest.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,6 @@ class QualityScale(IntEnum):
"gdacs",
"geonetnz_quakes",
"hyperion",
# Modbus is excluded because it doesn't have to have a config flow
# according to ADR-0010, since it's a protocol integration. This
# means that it can't implement diagnostics.
"modbus",
"nightscout",
"pvpc_hourly_pricing",
"risco",
Expand Down

0 comments on commit bc7d2d2

Please sign in to comment.