Fix common normalization for density histograms - #3982
Open
yushuosun wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hist._evalcurrently asks NumPy to normalize each semantic group independently whenstat="density". By the time seaborn applies itscommon_normgrouping, the original counts have already been lost.This keeps raw histogram counts in
_evaland moves density normalization into_normalize, alongside the other normalized statistics. As a result:common_norm=True;common_norm=False;common_normnormalizes within each requested subset.The full
_statstest suite passes (74 passed, 2 skipped), including three regression tests added here.This revives the approach from #3911, which was withdrawn by its author while the issue remained open. Thanks @Mr-Neutr0n for the original diagnosis and test cases.
Closes #3633.