Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NC28 #340

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Add support for NC28 #340

merged 1 commit into from
Apr 12, 2024

Conversation

darkfishy
Copy link
Contributor

Fixes #339
Doesn't seem to break anything on our prod install.
@mwalbeck Please review.

@darkfishy
Copy link
Contributor Author

No JS or CSS files have been modified, so I suspect that the checks are failing on master too.

@mwalbeck
Copy link
Owner

No JS or CSS files have been modified, so I suspect that the checks are failing on master too.

That is indeed correct

Thanks for the help, especially with testing, it's much appreciated!

@mwalbeck mwalbeck merged commit 084a1af into mwalbeck:master Apr 12, 2024
1 check failed
@IgorA100
Copy link

@mwalbeck @darkfishy
Why was NC27 support disabled?
I think we should have left NC27 support and added NC28

@mwalbeck
Copy link
Owner

@mwalbeck @darkfishy Why was NC27 support disabled? I think we should have left NC27 support and added NC28

It's just how the versioning for the theme is set up, so v27 of the theme only supports v27 of NC and so on. That's also why there is a branch for each major version of the theme, so updates can still be made to previous releases if necessary. I've done it quite a bit in the past, backporting changes whenever they were applicable to the previous release of the theme.

The reason for why I set it up this way, is not as applicable any more, but there used to be quite a lot of changes needed between major Nextcloud releases to support the next release. So it was quite a lot easier to make completely separate releases of the theme instead of trying to make them compatible with each other.

@IgorA100
Copy link

Thanks I got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to NC28 please
3 participants