Fix reliability issues when an existing ADB process is running - #36
Merged
Conversation
DonnchaC
changed the title
DonnchaC
changed the title
Collaborator
|
I can confirm that the bug exists on main branch and is not present on this branch. Tested on Arch Linux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to fix to issues which make AndroidQF acquistions unreliable.
We had one issue when AndroidQF tried to extract an
adbbinary in the current directory. It would try overwrite the binary even if it exists. This fails with atext file busyerror on Linux if the adb binary is still running. It's not possible to overwrite a running binary. One solution is to skip trying to open an asset if it already exists.There may also be an issue with multiple or older adb server processes being left running. I'm added a command to kill any running ADB server during start-up and killing it again before trying to delete the extracted asset files.
It will hopefully fix #32 and make the overall acquisition process more consistent and reliable between runs. Unfortunately I don't have access to an Android device currently to test.